Issue 4259059: Make flush discardable and lazily reset context

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4259059: Make flush discardable and lazily reset context (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by bsalomon

Modified:
13 years, 7 months ago

Reviewers:
junov, junov1, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Fix comments, remove resetContextHelper from GrGpuGL subclasses #

Patch Set 3 : make drawPixels call helper rather than infinite loop #

Total comments: 1

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+211 lines, -99 lines)			Patch
M	gpu/include/GrContext.h	View	1	3 chunks	+26 lines, -8 lines	0 comments	Download
M	gpu/include/GrGpu.h	View	1	13 chunks	+64 lines, -16 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View		2 chunks	+9 lines, -4 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1 2	8 chunks	+62 lines, -8 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View		4 chunks	+26 lines, -25 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View		10 chunks	+14 lines, -20 lines	0 comments	Download
M	gpu/src/GrGpuGLFixed.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	gpu/src/GrGpuGLFixed.cpp	View	1	3 chunks	+2 lines, -6 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders2.h	View	1	2 chunks	+1 line, -3 lines	0 comments	Download
M	gpu/src/GrGpuGLShaders2.cpp	View	1	3 chunks	+2 lines, -6 lines	1 comment	Download
M	xcode/sampleapp/SampleApp.xcodeproj/project.pbxproj	View		4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Contains some other minor changes like comment fixes, and including a PDF file in the ...

13 years, 7 months ago (2011-03-07 22:04:00 UTC) #1

junov1

13 years, 7 months ago (2011-03-09 17:00:27 UTC) #3

http://codereview.appspot.com/4259059/diff/6001/gpu/src/GrGpuGLShaders2.cpp
File gpu/src/GrGpuGLShaders2.cpp (left):

http://codereview.appspot.com/4259059/diff/6001/gpu/src/GrGpuGLShaders2.cpp#o...
gpu/src/GrGpuGLShaders2.cpp:1174: GrSamplerState::SampleMode mode =
Please remove this whitespace change.  The other changes to this file do not
interfere with my refactoring work, so we're good to go (thanks for asking).

Expand All Messages | Collapse All Messages