Issue 4254063: Prefer computed bounds to passed bounds when clip is a series of intersected rects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4254063: Prefer computed bounds to passed bounds when clip is a series of intersected rects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bsalomon

Modified:
13 years, 9 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -46 lines)			Patch
M	gpu/include/GrClip.h	View	1	5 chunks	+12 lines, -9 lines	0 comments	Download
M	gpu/src/GrClip.cpp	View	1	5 chunks	+21 lines, -23 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	1	4 chunks	+7 lines, -7 lines	0 comments	Download
M	gpu/src/GrInOrderDrawBuffer.cpp	View	1	1 chunk	+1 line, -4 lines	0 comments	Download
M	gpu/src/GrTextContext.cpp	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 3

bsalomon

We have an assert that when the clip is a single rect fBounds == fList[0].fRect. ...

13 years, 9 months ago (2011-03-08 20:27:11 UTC) #1

LGTM