Issue 4254048: Optimize focus_in to avoid call some UI blocking functions.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4254048: Optimize focus_in to avoid call some UI blocking functions. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Peng

Modified:
11 years, 9 months ago

Reviewers:
Yusuke Sato, yeh

CC:
satorux, oshima

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Optimize focus_in to avoid call some UI blocking functions. focus_in calls some X blocking functions. It will block UI. This change delays the X blocking calls to idle callback, to avoid blocking UI. BUG=http://crbug.com/74237 TEST=Linux desktop

Patch Set 1 #

Total comments: 2

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -27 lines)			Patch
	M	client/gtk2/ibusimcontext.c	View		8 chunks	+40 lines, -27 lines	2 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

LGTM, but I think the change description is too simple. Please make it clearer that ...

13 years, 4 months ago (2011-03-01 20:17:17 UTC) #2

Peng

http://codereview.appspot.com/4254048/diff/1/client/gtk2/ibusimcontext.c File client/gtk2/ibusimcontext.c (right): http://codereview.appspot.com/4254048/diff/1/client/gtk2/ibusimcontext.c#newcode851 client/gtk2/ibusimcontext.c:851: gdk_window_get_root_coords (ibusimcontext->client_window, On 2011/03/01 20:17:17, Yusuke Sato wrote: > ...

13 years, 4 months ago (2011-03-01 20:34:14 UTC) #3

yeh

11 years, 9 months ago (2012-09-06 11:36:24 UTC) #4

That change is a little bit broken, because because it uses g_idle_add_full with
a function that calls GDK functions, so it ends up calling the GDK functions
without the GDK locks. 

It needs to use gdk_threads_add_idle_full  instead.

Causes crashes (IO_error) in Ubunto 12.04 for one of our clients

Expand All Messages | Collapse All Messages