Issue 4250056: Add convex path detection to GrPath. Improve handling of complex clip.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4250056: Add convex path detection to GrPath. Improve handling of complex clip. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by bsalomon

Modified:
13 years, 10 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+707 lines, -279 lines)			Patch
M	gpu/include/GrClipIterator.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/include/GrDrawTarget.h	View	4 chunks	+7 lines, -3 lines	0 comments	Download
M	gpu/include/GrPath.h	View	2 chunks	+24 lines, -15 lines	0 comments	Download
M	gpu/include/GrPathIter.h	View	1 chunk	+17 lines, -57 lines	0 comments	Download
M	gpu/include/GrPoint.h	View	2 chunks	+48 lines, -1 line	0 comments	Download
M	gpu/include/GrRect.h	View	1 chunk	+14 lines, -0 lines	0 comments	Download
M	gpu/include/GrStencil.h	View	2 chunks	+2 lines, -3 lines	0 comments	Download
M	gpu/include/GrTypes.h	View	2 chunks	+98 lines, -13 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View	5 chunks	+24 lines, -8 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View	2 chunks	+13 lines, -1 line	0 comments	Download
M	gpu/src/GrGpuGLShaders2.cpp	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	gpu/src/GrPath.cpp	View	5 chunks	+326 lines, -49 lines	0 comments	Download
M	gpu/src/GrPathRenderer.h	View	3 chunks	+26 lines, -15 lines	0 comments	Download
M	gpu/src/GrPathRenderer.cpp	View	7 chunks	+35 lines, -27 lines	0 comments	Download
M	gpu/src/GrRedBlackTree.h	View	8 chunks	+9 lines, -7 lines	0 comments	Download
M	gpu/src/GrStencil.cpp	View	4 chunks	+38 lines, -60 lines	0 comments	Download
M	gpu/src/gr_unittests.cpp	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	include/gpu/SkGr.h	View	2 chunks	+10 lines, -10 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/SkGr.cpp	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

The rb tree change is unrelated, just something I noticed.

13 years, 10 months ago (2011-03-04 19:41:57 UTC) #1

reed1

13 years, 10 months ago (2011-03-04 19:46:09 UTC) #2

Will want to better scope these top-level enums in some later CL...

e.g.
kMove_GrPathCmd
or
class Gr { ...
or
namespace ...

LGTM

Expand All Messages | Collapse All Messages