Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(283)

Issue 4250041: Fix a race problem in SetGlobalEngine and add set_global_engine in python library (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Peng
Modified:
13 years, 4 months ago
Reviewers:
Yusuke Sato
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix a race problem in SetGlobalEngine and add set_global_engine in python library The race problem: 1. global engine == A 2. call SetGlobalEngine(B) asynchronously 3. call SetGlobalEngine(A) immediately 3.1 Because step 2 is not finished, so the global engine is still A, and SetGlobalEngine(A) returns sucessfully. 4. SetGlobalEngine(B) is completed and the global engine becomes B BUG=http://crosbug.com/12414 TEST=Linux desktop

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -19 lines) Patch
M bus/ibusimpl.c View 1 1 chunk +4 lines, -19 lines 0 comments Download
M ibus/bus.py View 1 chunk +3 lines, -0 lines 0 comments Download
M ibus/interface/iibus.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Peng
13 years, 4 months ago (2011-02-25 15:54:46 UTC) #1
Yusuke Sato
13 years, 4 months ago (2011-02-28 15:25:03 UTC) #2
LGTM, thanks.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b