Issue 4248081: Doc: Added @knownissue to NR for fingering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4248081: Doc: Added @knownissue to NR for fingering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by pkx166h

Modified:
13 years, 1 month ago

Reviewers:
Trevor Daniels, Neil Puttock, Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Doc: Added @knownissue to NR for fingering By default double-digit fingering (i.e. >9) is not possible using normal fingering markups. There is an LSR that has been posted for approval at the time of this patch, and will be included in the snippet link in the @seealso already in this section. Tidied up some grammar and minor punctuation changes.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Doc: Added @knownissue to NR for fingering #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -4 lines)			Patch
	M	Documentation/notation/editorial.itely	View	1	4 chunks	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/4248081/diff/1/Documentation/notation/editorial.itely File Documentation/notation/editorial.itely (right): http://codereview.appspot.com/4248081/diff/1/Documentation/notation/editorial.itely#newcode217 Documentation/notation/editorial.itely:217: By default, numbers greater than 9 are not ...

13 years, 1 month ago (2011-03-10 21:07:27 UTC) #1

Graham Percival (old account)

LGTM, go ahead and push after fixing Neil's thing.

13 years, 1 month ago (2011-03-11 23:21:48 UTC) #3

pkx166h

On 2011/03/11 23:21:48, Graham Percival wrote: > LGTM, go ahead and push after fixing Neil's ...

13 years, 1 month ago (2011-03-12 18:14:24 UTC) #4

pkx166h

13 years, 1 month ago (2011-03-15 18:29:02 UTC) #5

Pushed as f93bc90b3ee5e5de96b59c8e81b4ea354d5b1927

Only @knownissue added.

Solving issue.

Expand All Messages | Collapse All Messages