Issue 4248053: Use minput_list() instead of mdatabase_list().

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4248053: Use minput_list() instead of mdatabase_list(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Daiki Ueno

Modified:
13 years, 1 month ago

Reviewers:
shawn.p.huang

CC:
Yusuke Sato

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Use minput_list() instead of mdatabase_list(). m17n-lib 1.6.2+ (CVS) provides a new function minput_list(), which enumerates input methods in a robuster way than mdatabase_list(Minput_method, ...). This patch is to use minput_list() if available. BUG=none TEST=manual

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -18 lines)			Patch
	configure.ac	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/Makefile.am	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/m17nutil.c	View	2 chunks	+23 lines, -18 lines	0 comments	Download
A	src/minput_list.c	View	1 chunk	+35 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

LGTM. BTW, I found current HEAD can not build with ibus-1.4 successfully. Could you also ...

13 years, 1 month ago (2011-03-03 03:26:29 UTC) #2

Daiki Ueno

13 years, 1 month ago (2011-03-03 06:08:08 UTC) #3

On 2011/03/03 03:26:29, Peng wrote:
> LGTM.
> 
> BTW, I found current HEAD can not build with ibus-1.4 successfully. Could you
> also fix it?

Sure, I will file a new review request for that.

Expand All Messages | Collapse All Messages