Issue 4245044: [PDF] Fix broken encoding conversion code for non-multibyte fonts.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4245044: [PDF] Fix broken encoding conversion code for non-multibyte fonts. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Steve VanDeBogart

Modified:
13 years, 7 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Fix broken encoding conversion code for non-multibyte fonts. Committed: http://code.google.com/p/skia/source/detail?r=863

Patch Set 2 : Fix nit and small bug in update #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -58 lines)			Patch
M	include/pdf/SkPDFFont.h	View		1 chunk	+4 lines, -10 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View		3 chunks	+18 lines, -26 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View	1	1 chunk	+13 lines, -22 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Steve VanDeBogart

I think this will fix the problem. I tested it with TT, but not Type ...

13 years, 7 months ago (2011-02-26 03:05:27 UTC) #1

Chris Guillory

LGTM. Thanks for fixing and making cleaner. http://codereview.appspot.com/4245044/diff/1/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): http://codereview.appspot.com/4245044/diff/1/src/pdf/SkPDFFont.cpp#newcode334 src/pdf/SkPDFFont.cpp:334: // A ...

13 years, 7 months ago (2011-02-26 03:19:48 UTC) #2

Steve VanDeBogart

13 years, 7 months ago (2011-02-28 19:51:14 UTC) #3

http://codereview.appspot.com/4245044/diff/1/src/pdf/SkPDFFont.cpp
File src/pdf/SkPDFFont.cpp (right):

http://codereview.appspot.com/4245044/diff/1/src/pdf/SkPDFFont.cpp#newcode334
src/pdf/SkPDFFont.cpp:334: // A font with multibyte glyphs will support all
glyph IDs in a single font.
On 2011/02/26 03:19:48, Chris Guillory wrote:
> Nit: ',' instead of '.' or Capitalize "shortcut"?

Fixed.  I didn't intend to leave that line in.

Expand All Messages | Collapse All Messages