Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2732)

Issue 4244064: Adds automatic numbering to footnotes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by MikeSol
Modified:
12 years, 9 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Adds automatic numbering to footnotes.

Patch Set 1 : Adds automatic numbering to footnotes. #

Patch Set 2 : Fixes from Neil and Bertrand #

Patch Set 3 : Sketch for two pass numbering system #

Patch Set 4 : Adds more informative comments to page-layout-problem.cc #

Patch Set 5 : Fixes file naming for note file #

Patch Set 6 : Bug fix for page resetting #

Total comments: 1

Patch Set 7 : Most recent work. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+560 lines, -89 lines) Patch
M input/regression/footnote.ly View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A input/regression/footnote-auto-numbering.ly View 1 chunk +40 lines, -0 lines 0 comments Download
A input/regression/footnote-auto-numbering-page-reset.ly View 1 chunk +40 lines, -0 lines 0 comments Download
M input/regression/footnote-break-visibility.ly View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M input/regression/footnote-spanner.ly View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M lily/align-interface.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M lily/balloon.cc View 1 2 3 4 2 chunks +12 lines, -4 lines 0 comments Download
M lily/constrained-breaking.cc View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/page-breaking.hh View 1 2 3 4 5 6 3 chunks +4 lines, -2 lines 0 comments Download
M lily/include/page-layout-problem.hh View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M lily/include/system.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/output-def-scheme.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/page-breaking.cc View 1 2 3 4 5 6 6 chunks +36 lines, -15 lines 0 comments Download
M lily/page-layout-problem.cc View 1 2 3 4 5 6 7 chunks +205 lines, -13 lines 0 comments Download
M lily/page-spacing.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M lily/paper-book.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M lily/paper-system.cc View 2 chunks +4 lines, -11 lines 0 comments Download
M lily/system.cc View 1 2 3 4 1 chunk +8 lines, -23 lines 0 comments Download
M ly/init.ly View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 4 5 6 2 chunks +31 lines, -2 lines 0 comments Download
M ly/paper-defaults-init.ly View 1 2 3 4 5 6 1 chunk +5 lines, -1 line 0 comments Download
M scm/define-grob-properties.scm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 4 5 6 3 chunks +5 lines, -0 lines 0 comments Download
M scm/define-markup-commands.scm View 1 2 3 4 5 6 2 chunks +70 lines, -9 lines 0 comments Download
M scm/file-cache.scm View 1 2 3 4 5 1 chunk +33 lines, -0 lines 0 comments Download
M scm/lily-library.scm View 1 chunk +17 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 22
Bertrand Bordage
Hi Mike, Nice job, as usual ! However, I noticed some obvious problems. You probably ...
13 years ago (2011-03-09 17:38:01 UTC) #1
mike_apollinemike.com
Thanks for the helpful comments! Responses inlined below. On Mar 9, 2011, at 6:38 PM, ...
13 years ago (2011-03-09 19:13:20 UTC) #2
Colin Campbell
On 2011/03/09 19:13:20, mike_apollinemike.com wrote: > Thanks for the helpful comments! Responses inlined below. Hi, ...
13 years ago (2011-03-09 21:14:08 UTC) #3
Neil Puttock
Hi Mike, I've only given this a quick look so far, but it's looking great. ...
13 years ago (2011-03-09 21:17:32 UTC) #4
mike_apollinemike.com
On Mar 9, 2011, at 10:14 PM, ColinPKCampbell@gmail.com wrote: > On 2011/03/09 19:13:20, mike_apollinemike.com wrote: ...
13 years ago (2011-03-10 07:57:50 UTC) #5
mike_apollinemike.com
On Mar 9, 2011, at 10:17 PM, n.puttock@gmail.com wrote: > Hi Mike, > > I've ...
13 years ago (2011-03-10 10:06:41 UTC) #6
mike_apollinemike.com
On Mar 9, 2011, at 6:38 PM, bordage.bertrand@gmail.com wrote: > Hi Mike, > > Nice ...
13 years ago (2011-03-10 10:24:52 UTC) #7
Bertrand Bordage
There is still a vertical spacing bug in the footnotes : \markup { \footnote e ...
13 years ago (2011-03-10 11:02:36 UTC) #8
mike_apollinemike.com
On Mar 10, 2011, at 12:02 PM, bordage.bertrand@gmail.com wrote: > There is still a vertical ...
13 years ago (2011-03-10 11:11:56 UTC) #9
mike_apollinemike.com
On Mar 10, 2011, at 12:11 PM, mike@apollinemike.com wrote: > On Mar 10, 2011, at ...
13 years ago (2011-03-11 10:41:56 UTC) #10
mike_apollinemike.com
On Mar 11, 2011, at 5:41 AM, mike@apollinemike.com wrote: > On Mar 10, 2011, at ...
13 years ago (2011-03-16 15:44:20 UTC) #11
hanwenn
On Wed, Mar 16, 2011 at 12:44 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > The problem is ...
13 years ago (2011-03-19 15:01:43 UTC) #12
mike_apollinemike.com
On Mar 19, 2011, at 11:01 AM, Han-Wen Nienhuys wrote: > On Wed, Mar 16, ...
13 years ago (2011-03-19 15:06:47 UTC) #13
hanwenn
On Sat, Mar 19, 2011 at 12:06 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: >> On Wed, Mar ...
13 years ago (2011-03-19 15:58:39 UTC) #14
mike_apollinemike.com
On Mar 19, 2011, at 11:58 AM, Han-Wen Nienhuys wrote: > On Sat, Mar 19, ...
13 years ago (2011-03-19 16:07:47 UTC) #15
hanwenn
On Sat, Mar 19, 2011 at 1:07 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: > One way to ...
13 years ago (2011-03-19 16:14:44 UTC) #16
mike_apollinemike.com
On Mar 19, 2011, at 12:14 PM, Han-Wen Nienhuys wrote: > On Sat, Mar 19, ...
13 years ago (2011-03-19 16:20:14 UTC) #17
hanwenn
On Sat, Mar 19, 2011 at 1:20 PM, mike@apollinemike.com <mike@apollinemike.com> wrote: >> You realize that ...
13 years ago (2011-03-19 16:27:24 UTC) #18
Bertrand Bordage
Of course, I agree that we should get rid of the two-pass algorithm. But it's ...
13 years ago (2011-03-22 15:28:16 UTC) #19
Neil Puttock
On 10 March 2011 10:06, mike@apollinemike.com <mike@apollinemike.com> wrote: > On Mar 9, 2011, at 10:17 ...
13 years ago (2011-03-22 23:35:18 UTC) #20
mike_apollinemike.com
On Mar 22, 2011, at 11:28 AM, bordage.bertrand@gmail.com wrote: > Of course, I agree that ...
13 years ago (2011-03-23 10:46:36 UTC) #21
mike_apollinemike.com
13 years ago (2011-03-23 10:55:53 UTC) #22
On Mar 22, 2011, at 7:35 PM, Neil Puttock wrote:

> On 10 March 2011 10:06, mike@apollinemike.com <mike@apollinemike.com> wrote:
>> On Mar 9, 2011, at 10:17 PM, n.puttock@gmail.com wrote:
> 
>>> Does `annotation-whiteout' do anything special?  If not, the existing
>>> property `whiteout' should suffice.
>>> 
>> 
>> It puts a whiteout only around the annotation instead of whiting out the
entire grob (line + annotation).
> 
> You're only using it for automatic numbering, so it could be
> incorporated into the markup command instead.
> 
> If you still think it's necessary though, you need to rethink the way
> the whiteout's being applied; currently, you're applying
> `stencil-whiteout' to the evaluated markup, then setting 'text to the
> new value.  You can't do this since it's a property type mismatch:
> 'text expects markup, not a stencil.

A workaround would be to create a markup in page-layout-problem.cc, in which
case my question would be: is there a clean way to create markups on the C++
side, or should I create a public scheme function & call it from the C++ side?

Cheers,
MS
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b