Issue 4243060: Fix candidate for 1506

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4243060: Fix candidate for 1506 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by MikeSol

Modified:
13 years, 10 months ago

Reviewers:
Graham Percival (old account), hanwenn

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	lily/staff-symbol.cc	View		1 chunk	+0 lines, -3 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Graham Percival (old account)

Thanks, added to http://code.google.com/p/lilypond/issues/detail?id=1506

14 years, 1 month ago (2011-04-08 03:28:26 UTC) #1

hanwenn

http://codereview.appspot.com/4243060/diff/1/lily/staff-symbol.cc File lily/staff-symbol.cc (left): http://codereview.appspot.com/4243060/diff/1/lily/staff-symbol.cc#oldcode72 lily/staff-symbol.cc:72: span_points[d] += x->extent (x, X_AXIS)[d]; it's reasonable for people ...

14 years, 1 month ago (2011-04-08 04:36:40 UTC) #3

MikeSol

14 years, 1 month ago (2011-04-08 10:39:36 UTC) #4

Neil sent an alternative out to lilypond-devel on March 26th with his own patch.
 It seems to be better than this one.  Neil - can you please throw it up on
Rietveld?

Cheers,
Mike

Expand All Messages | Collapse All Messages