Issue 4242041: Make class name parsing robuster.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4242041: Make class name parsing robuster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 2 months ago by Daiki Ueno

Modified:
13 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Make class name parsing robuster. ibus-m17n uses "IBusM17N<Lang><Name>Engine" for dynamically allocated GTypes. However, when parsing it back, if <Name> contains a non-alphabet character, ibus-m17n fails to parse. For example, IBusM17NHiInscript2Engine for the hi-inscript2 map, which Indic people are currently working on. This patch fixes the problem. BUG=none TEST=manual

Patch Set 1 #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/engine.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

On 2011/02/25 06:05:41, Daiki Ueno wrote:

lgtm

Expand All Messages | Collapse All Messages