Issue 4241058: Remove connection from hash table before cleanup to avoid recursing.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4241058: Remove connection from hash table before cleanup to avoid recursing. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by zork

Modified:
13 years, 3 months ago

Reviewers:
shawn.p.huang, Yusuke Sato

Visibility:
Public.

Description

This can cause crashes on cleanup when multiple components are implemented in the same process.

Patch Set 1 #

Patch Set 2 : Code Review #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/ibusservice.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

submitted. https://github.com/ibus/ibus/commit/71bcf46f2aac7a81291bf2782915b8bf4cc36edf On 2011/03/12 05:08:54, Peng wrote: > On 2011/03/10 06:03:22, zork wrote: > LGTM

13 years, 3 months ago (2011-03-14 06:43:52 UTC) #3

Yusuke Sato

13 years, 3 months ago (2011-03-16 05:32:39 UTC) #4

Zach, Peng, please close this issue.

On 2011/03/14 06:43:52, Yusuke Sato wrote:
> submitted.
> https://github.com/ibus/ibus/commit/71bcf46f2aac7a81291bf2782915b8bf4cc36edf
> 
> On 2011/03/12 05:08:54, Peng wrote:
> > On 2011/03/10 06:03:22, zork wrote:
> > LGTM

Expand All Messages | Collapse All Messages