Issue 4240070: Fix build with ibus-1.4.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4240070: Fix build with ibus-1.4. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Daiki Ueno

Modified:
13 years, 1 month ago

Reviewers:
shawn.p.huang, Peng

Base URL:
git@github.com:ibus/ibus-m17n.git@master

Visibility:
Public.

Description

Fix build with ibus-1.4. This patch adds compatibility code for the API changes of IBusConfig and IBusEngineDesc in ibus-1.3 -> ibus-1.4. BUG=none TEST=manual

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+204 lines, -76 lines)			Patch
M	src/engine.c	View	4 chunks	+40 lines, -33 lines	0 comments	Download
M	src/m17nutil.h	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	src/m17nutil.c	View	3 chunks	+110 lines, -0 lines	0 comments	Download
M	src/main.c	View	1 chunk	+8 lines, -3 lines	0 comments	Download
M	src/setup.c	View	9 chunks	+30 lines, -40 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Daiki Ueno

On 2011/03/04 03:00:46, Daiki Ueno wrote: BTW, shall we make a new release of ibus-m17n? ...

13 years, 1 month ago (2011-03-07 01:22:22 UTC) #2

Peng

13 years, 1 month ago (2011-03-07 01:29:16 UTC) #3

LGTM. 

OK. Please release a new version. and upload it to ibus.googlecode.com. Thanks.
On 2011/03/07 01:22:22, Daiki Ueno wrote:
> On 2011/03/04 03:00:46, Daiki Ueno wrote:
> 
> BTW, shall we make a new release of ibus-m17n?  There has been no release for
6
> months and the diff from 1.3.1 now exceeds 1000 lines.  I'm thinking of one
more
> change to add --with-gtk=2.0|3.0|no option to support GTK3 before the release
> though.

Expand All Messages | Collapse All Messages