Issue 4220048: quote all config and urlparam values

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4220048: quote all config and urlparam values (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by johnfargo

Modified:
15 years ago

Reviewers:
dev-remailer, mhermanto

Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/

Visibility:
Public.

Description

...as more preparation (following on to CL http://codereview.appspot.com/4220047/) for property obfuscation. These values are referred to by literal name, as provided in query strings and config files.

Patch Set 1 #

Created: 15 years ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Stats (+36 lines, -36 lines)			Patch
features/src/main/javascript/features/core.io/io.js	View	3 chunks	+7 lines, -7 lines	0 comments	Download
features/src/main/javascript/features/minimessage/minimessage.js	View	1 chunk	+1 line, -1 line	0 comments	Download
features/src/main/javascript/features/rpc/rpc.js	View	4 chunks	+8 lines, -8 lines	0 comments	Download
features/src/main/javascript/features/setprefs/setprefs.js	View	1 chunk	+2 lines, -2 lines	0 comments	Download
features/src/main/javascript/features/shindig.auth/auth.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
features/src/main/javascript/features/shindig.xhrwrapper/xhrwrapper.js	View	2 chunks	+8 lines, -8 lines	0 comments	Download
features/src/main/javascript/features/skins/skins.js	View	1 chunk	+1 line, -1 line	0 comments	Download
features/src/main/javascript/features/tabs/tabs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
features/src/main/javascript/features/views/views.js	View	3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

johnfargo

15 years ago (2011-02-25 01:00:53 UTC) #2

CL retracted; Michael took care of it. Thanks Michael!

On 2011/02/24 23:11:29, johnfargo wrote:

Expand All Messages | Collapse All Messages