Issue 4185056: Remove glGet calls for stencil bits, also cleanup gl vs. gr irects

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4185056: Remove glGet calls for stencil bits, also cleanup gl vs. gr irects (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by bsalomon

Modified:
13 years, 7 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+222 lines, -139 lines)			Patch
M	gpu/include/GrContext.h	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	gpu/include/GrGLConfig.h	View	1 2	1 chunk	+96 lines, -0 lines	0 comments	Download
M	gpu/include/GrGLTexture.h	View		5 chunks	+25 lines, -22 lines	0 comments	Download
M	gpu/include/GrGpu.h	View	1	2 chunks	+2 lines, -6 lines	0 comments	Download
M	gpu/include/GrTexture.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	gpu/include/GrUserConfig.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	gpu/src/GrContext.cpp	View		1 chunk	+5 lines, -3 lines	0 comments	Download
M	gpu/src/GrGLTexture.cpp	View		2 chunks	+12 lines, -11 lines	0 comments	Download
M	gpu/src/GrGpuGL.h	View		3 chunks	+7 lines, -29 lines	0 comments	Download
M	gpu/src/GrGpuGL.cpp	View		13 chunks	+65 lines, -63 lines	0 comments	Download

Total messages: 3

bsalomon

13 years, 7 months ago (2011-02-18 16:10:11 UTC) #3

On 2011/02/18 15:40:28, reed1 wrote:
> Can GrGLIRect be in its own header?

Done, and checked in.

> 
> LGTM