Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1865)

Issue 4179061: Add asynchronous APIs to ibusbus.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Yusuke Sato
Modified:
13 years, 3 months ago
Reviewers:
Peng Huang
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add asynchronous APIs to ibusbus.h Modified src/tests/ibus-bus.c so that it could be compiled with ibus-1.3.99 as well. BUG=chromium-os:12581 TEST=added async api tests to the src/tests/ibus-bus.c and ran it locally.

Patch Set 1 #

Patch Set 2 : review fix #

Total comments: 2

Patch Set 3 : review fix 2 #

Patch Set 4 : finished except header comments #

Patch Set 5 : added tests #

Patch Set 6 : review #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1716 lines, -157 lines) Patch
M src/ibusbus.h View 1 2 3 4 5 11 chunks +532 lines, -38 lines 0 comments Download
M src/ibusbus.c View 1 2 3 4 27 chunks +674 lines, -44 lines 0 comments Download
M src/tests/ibus-bus.c View 1 2 3 4 5 2 chunks +510 lines, -75 lines 0 comments Download

Messages

Total messages: 6
Peng Huang
http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c File src/ibusbus.c (right): http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c#newcode423 src/ibusbus.c:423: return g_strdup (path); I think maybe we don't need ...
13 years, 4 months ago (2011-03-01 16:52:30 UTC) #1
Yusuke Sato
http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c File src/ibusbus.c (right): http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c#newcode423 src/ibusbus.c:423: return g_strdup (path); On 2011/03/01 16:52:30, Peng Huang wrote: ...
13 years, 4 months ago (2011-03-01 17:01:06 UTC) #2
Yusuke Sato
Almost done (patch set #4). I've added async versions for all APIs. I'll write header ...
13 years, 4 months ago (2011-03-01 20:08:03 UTC) #3
Yusuke Sato
Peng, all done. Please review. On 2011/03/01 20:08:03, Yusuke Sato wrote: > Almost done (patch ...
13 years, 3 months ago (2011-03-06 14:03:38 UTC) #4
Peng Huang
LGTM. On 2011/03/06 14:03:38, Yusuke Sato wrote: > Peng, all done. Please review. > > ...
13 years, 3 months ago (2011-03-07 15:42:17 UTC) #5
Peng Huang
13 years, 3 months ago (2011-03-07 17:59:28 UTC) #6
Found a problem. make dpkg failed. Because of lack new symbols in
debian/libibus-xx.symbols

On 2011/03/07 15:42:17, Peng Huang wrote:
> LGTM.
> 
> On 2011/03/06 14:03:38, Yusuke Sato wrote:
> > Peng, all done. Please review.
> > 
> > On 2011/03/01 20:08:03, Yusuke Sato wrote:
> > > Almost done (patch set #4). I've added async versions for all APIs.
> > > 
> > > I'll write header comments and tests when I get back in Tokyo, and then
will
> > > start (official) code review.
> > > 
> > > On 2011/03/01 17:01:06, Yusuke Sato wrote:
> > > > http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c
> > > > File src/ibusbus.c (right):
> > > > 
> > > > http://codereview.appspot.com/4179061/diff/2001/src/ibusbus.c#newcode423
> > > > src/ibusbus.c:423: return g_strdup (path);
> > > > On 2011/03/01 16:52:30, Peng Huang wrote:
> > > > > I think maybe we don't need strdup the path, and just return const
> gchar*;
> > > > 
> > > > Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b