Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(662)

Issue 4178063: Add asAGradient shader extraction API. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Steve VanDeBogart
Modified:
13 years, 8 months ago
Reviewers:
bsalomon, reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add asAGradient shader extraction API. Store initial gradient parameters. Add compile asserts in GPU code for BitmapType ordering. Committed: http://code.google.com/p/skia/source/detail?r=845

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments. #

Patch Set 3 : Revert SkImage_BitmapType change. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+235 lines, -48 lines) Patch
M include/core/SkColorShader.h View 1 chunk +3 lines, -0 lines 0 comments Download
M include/core/SkShader.h View 1 2 3 chunks +56 lines, -2 lines 0 comments Download
M src/core/SkShader.cpp View 4 chunks +23 lines, -10 lines 0 comments Download
M src/effects/SkGradientShader.cpp View 1 12 chunks +146 lines, -35 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 7
Steve VanDeBogart
See http://codereview.appspot.com/4171061/ for an example of the new API being used.
13 years, 8 months ago (2011-02-18 00:02:44 UTC) #1
Steve VanDeBogart
See http://codereview.appspot.com/4171061/ for an example of the new API being used.
13 years, 8 months ago (2011-02-18 00:03:23 UTC) #2
reed1
http://codereview.appspot.com/4178063/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): http://codereview.appspot.com/4178063/diff/1/include/core/SkShader.h#newcode157 include/core/SkShader.h:157: kImage_BitmapType, //<! Use a multidimensional bitmap as a texture. ...
13 years, 8 months ago (2011-02-18 12:48:48 UTC) #3
Steve VanDeBogart
http://codereview.appspot.com/4178063/diff/1/include/core/SkShader.h File include/core/SkShader.h (right): http://codereview.appspot.com/4178063/diff/1/include/core/SkShader.h#newcode157 include/core/SkShader.h:157: kImage_BitmapType, //<! Use a multidimensional bitmap as a texture. ...
13 years, 8 months ago (2011-02-22 22:38:36 UTC) #4
reed1
I would prefer we drop kDefault, and just use kImage, assuming it is reasonable for ...
13 years, 8 months ago (2011-02-23 14:33:21 UTC) #5
Steve VanDeBogart
On 2011/02/23 14:33:21, reed1 wrote: > I would prefer we drop kDefault, and just use ...
13 years, 8 months ago (2011-02-23 17:47:10 UTC) #6
reed1
13 years, 8 months ago (2011-02-23 18:21:23 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b