Batch rectToRect draws in GrInOrderDrawBuffer

[reed1, 2011-02-16 15:23:06]

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrContext.h
File gpu/include/GrContext.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrContext.h#newc...
gpu/include/GrContext.h:451: enum DrawCategory {
Lets add some simple 1-liner comments as we add new stuff, just on principle.

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h
File gpu/include/GrGpu.h (left):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h#oldcode308
gpu/include/GrGpu.h:308: * Indices are 0, 1, 2, 0, 2, 3, etc.
Do you mean Six instead of Size?

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h
File gpu/include/GrGpu.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h#newcode348
gpu/include/GrGpu.h:348: virtual void clipWillBeSet(const GrClip& newClip);
one line comment?

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrRect.h
File gpu/include/GrRect.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrRect.h#newcode134
gpu/include/GrRect.h:134: explicit GrRect(GrPoint pt) {
const GrPoint&

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp
File gpu/src/GrContext.cpp (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp#newcod...
gpu/src/GrContext.cpp:459: const GrMatrix*
srcMatrices[GrDrawTarget::kNumStages];
Can we use this?

const GrRect* srcRects[blahblahblah] = {};

or

sk_bzero(srcRects, sizeof(srcRects));

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp#newcod...
gpu/src/GrContext.cpp:889: #if BATCH_RECT_TO_RECT || DEFER_TEXT
Is it DEFER_TEXT or DEFER_TEXT_RENDERING ?

[bsalomon, 2011-02-16 16:01:56]

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrContext.h
File gpu/include/GrContext.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrContext.h#newc...
gpu/include/GrContext.h:451: enum DrawCategory {
On 2011/02/16 15:23:07, reed1 wrote:
> Lets add some simple 1-liner comments as we add new stuff, just on principle.

Done.

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h
File gpu/include/GrGpu.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrGpu.h#newcode348
gpu/include/GrGpu.h:348: virtual void clipWillBeSet(const GrClip& newClip);
On 2011/02/16 15:23:07, reed1 wrote:
> one line comment?

Done.

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrRect.h
File gpu/include/GrRect.h (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/include/GrRect.h#newcode134
gpu/include/GrRect.h:134: explicit GrRect(GrPoint pt) {
On 2011/02/16 15:23:07, reed1 wrote:
> const GrPoint&

Done.

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp
File gpu/src/GrContext.cpp (right):

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp#newcod...
gpu/src/GrContext.cpp:459: const GrMatrix*
srcMatrices[GrDrawTarget::kNumStages];
On 2011/02/16 15:23:07, reed1 wrote:
> Can we use this?
> 
> const GrRect* srcRects[blahblahblah] = {};
> 
> or
> 
> sk_bzero(srcRects, sizeof(srcRects));

Done.

http://codereview.appspot.com/4178057/diff/12001/gpu/src/GrContext.cpp#newcod...
gpu/src/GrContext.cpp:889: #if BATCH_RECT_TO_RECT || DEFER_TEXT
On 2011/02/16 15:23:07, reed1 wrote:
> Is it DEFER_TEXT or DEFER_TEXT_RENDERING ? 

Done.

[reed1, 2011-02-16 16:06:15]

LGTM