Issue 4178045: [PATCH] Add CMake dependencies so that LLVM_USED_LIBS order doesn't matter

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4178045: [PATCH] Add CMake dependencies so that LLVM_USED_LIBS order doesn't matter (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Jeffrey Yasskin

Modified:
13 years, 9 months ago

Reviewers:
cfe-commits

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Description

chapuni asked me to split this out of http://codereview.appspot.com/4152043/. It's probably not the complete set of dependencies we need to add, but it makes the new unittest work.

Patch Set 1 #

Patch Set 2 : Sort #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -14 lines)			Patch
M	lib/AST/CMakeLists.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/Basic/CMakeLists.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/CodeGen/CMakeLists.txt	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	lib/Frontend/CMakeLists.txt	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	lib/Lex/CMakeLists.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/Serialization/CMakeLists.txt	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	lib/StaticAnalyzer/Core/CMakeLists.txt	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/driver/CMakeLists.txt	View		1 chunk	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Jeffrey Yasskin

13 years, 9 months ago (2011-02-11 08:47:19 UTC) #1

Initial patch at http://codereview.appspot.com/download/issue4178045_1.diff

Expand All Messages | Collapse All Messages