Issue 4177045: Add engine_name parameter to the global-engine-changed signal.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4177045: Add engine_name parameter to the global-engine-changed signal. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by Yusuke Sato

Modified:
13 years, 4 months ago

Reviewers:
shawn.p.huang, Peng Huang

CC:
satorux

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add engine_name parameter to the global-engine-changed signal. This makes it possible for a client to know the current global engine w/o issuing GetGlobalEngine reqeust. BUG=chromium-os:11908

Patch Set 2 : review fix #

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -5 lines)			Patch
	M	bus/ibusimpl.c	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
	M	src/ibusbus.c	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

LGTM http://codereview.appspot.com/4177045/diff/1/src/ibusbus.c File src/ibusbus.c (right): http://codereview.appspot.com/4177045/diff/1/src/ibusbus.c#newcode145 src/ibusbus.c:145: G_TYPE_NONE, 1, I prefer to make 1 in ...

13 years, 4 months ago (2011-02-14 15:47:53 UTC) #2

Yusuke Sato

13 years, 4 months ago (2011-02-15 07:47:48 UTC) #3

http://codereview.appspot.com/4177045/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4177045/diff/1/src/ibusbus.c#newcode145
src/ibusbus.c:145: G_TYPE_NONE, 1,
On 2011/02/14 15:47:53, Shawn.P.Huang wrote:
> I prefer to make 1 in a new line.

Done.

Expand All Messages | Collapse All Messages