Add async version of set_global_engine.

Add async version of set_global_engine.

Patch from Zach Kuznia <zork@chromium.org>, modified by Yusuke Sato <yusukes@chromium.org>.

[Yusuke Sato, 2011-02-14 07:37:27]

Peng, please review the change. I'll use the async API in Chromium OS (libcros.)

Zach, I've modified your change to follow Peng's plan at
http://codereview.appspot.com/4185041/diff/1/src/ibusconfig.c#newcode276 .

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h
File src/ibusbus.h (right):

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h#newcode132
src/ibusbus.h:132: guint        ibus_bus_request_name      (IBusBus        *bus,
Should we change the function name to ibus_bus_request_name_sync now?

[Peng, 2011-02-15 04:28:27]

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h
File src/ibusbus.h (right):

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h#newcode132
src/ibusbus.h:132: guint        ibus_bus_request_name      (IBusBus        *bus,
On 2011/02/14 07:37:27, Yusuke Sato wrote:
> Should we change the function name to ibus_bus_request_name_sync now?

Probably break API is not a good idea. Many IMEs need modifications. I think we
have to add new async APIs like:

ibus_xxx_async
ibus_xxx_async_finish

[Yusuke Sato, 2011-02-15 09:30:50]

Please take another look.

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h
File src/ibusbus.h (right):

http://codereview.appspot.com/4175047/diff/4001/src/ibusbus.h#newcode132
src/ibusbus.h:132: guint        ibus_bus_request_name      (IBusBus        *bus,
On 2011/02/15 04:28:27, Shawn.P.Huang wrote:
> On 2011/02/14 07:37:27, Yusuke Sato wrote:
> > Should we change the function name to ibus_bus_request_name_sync now?
> 
> Probably break API is not a good idea. Many IMEs need modifications. I think
we
> have to add new async APIs like:
> 
> ibus_xxx_async
> ibus_xxx_async_finish
> 

Done.

[Peng, 2011-02-15 16:04:48]

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1026
src/ibusbus.c:1026: ibus_bus_set_global_engine,
Should be ibus_bus_set_global_engine_async

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1040
src/ibusbus.c:1040: ibus_bus_set_global_engine));
Should be ibus_bus_set_global_engine_async

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1105
src/ibusbus.c:1105: g_simple_async_result_complete (simple);
I think you should unref simple here. Please check it.

[Yusuke Sato, 2011-02-16 07:04:21]

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1026
src/ibusbus.c:1026: ibus_bus_set_global_engine,
On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> Should be ibus_bus_set_global_engine_async

Done. thx.

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1040
src/ibusbus.c:1040: ibus_bus_set_global_engine));
On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> Should be ibus_bus_set_global_engine_async

Done.

http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1105
src/ibusbus.c:1105: g_simple_async_result_complete (simple);
On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> I think you should unref simple here. Please check it.

Done.

[Peng, 2011-02-16 13:49:51]

On 2011/02/16 07:04:21, Yusuke Sato wrote:
> http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c
> File src/ibusbus.c (right):
> 
> http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1026
> src/ibusbus.c:1026: ibus_bus_set_global_engine,
> On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> > Should be ibus_bus_set_global_engine_async
> 
> Done. thx.
> 
> http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1040
> src/ibusbus.c:1040: ibus_bus_set_global_engine));
> On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> > Should be ibus_bus_set_global_engine_async
> 
> Done.
> 
> http://codereview.appspot.com/4175047/diff/9001/src/ibusbus.c#newcode1105
> src/ibusbus.c:1105: g_simple_async_result_complete (simple);
> On 2011/02/15 16:04:48, Shawn.P.Huang wrote:
> > I think you should unref simple here. Please check it.
> 
> Done.

LGTM