Possible pydoc.py changes

[ron3200, 2011-02-19 06:56:50]

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py
File Lib/pydoc.py (left):

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#oldcode1532
Lib/pydoc.py:1532: def doc(thing, title='Python Library Documentation: %s',
forceload=0,
Use render_doc function instead.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#oldcode2048
Lib/pydoc.py:2048: 
This is the old web page interface which is to be removed in python 3.3.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py
File Lib/pydoc.py (right):

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode223
Lib/pydoc.py:223: def synopsis(filename, cache={}):
The source_synopsis() function is used in it's place which parses the source
instead of importing the module.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode1556
Lib/pydoc.py:1556: class HelpData:
Seperates the topics data handling from the command line tool and has a single
_gettopic() method as a interface to get topics, keywords, and symbols.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode1726
Lib/pydoc.py:1726: def _gettopic(self, topic, more_xrefs=[]):
This function can be cleaned up a lot if the three dictionaries are updated to
use the same format.  Even better to move the xrefs to pydoc_data/topics.py if
it's possible to auto-generate them from the docs.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode1806
Lib/pydoc.py:1806: desc = source_synopsis(io.StringIO(source)) or ''
It might be good to make the source_synopsis() a method in the module scanner
also.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode1862
Lib/pydoc.py:1862: class Helper(cmd.Cmd):
This class would be simpler, but we have to include some extra methods to make
it's behavior match the existing help.

[ron3200, 2011-02-19 07:04:33]

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py
File Lib/pydoc.py (right):

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode1927
Lib/pydoc.py:1927: pager(text)
This is the only call to the pager.

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode2449
Lib/pydoc.py:2449: if opt == '-g':
Will remove the -g options in python3.3

http://codereview.appspot.com/4173064/diff/1/Lib/pydoc.py#newcode2456
Lib/pydoc.py:2456: help('modules ' + val)
I wonder if the -k option is even needed.
python3.2 -m pydoc 'modules text' works for this also.