Support unicode to glyph id conversion in windows for non-BMP characters.

Support unicode to glyph id conversion in windows for non-BMP characters.

BUG=144


Committed: http://code.google.com/p/skia/source/detail?r=839

[Chris Guillory, 2011-02-17 23:05:57]

Ready for review. I've manually tested this by generating a pdf with the
following character in the font Code2001.
http://www.fileformat.info/info/unicode/char/20027/index.htm

[Steve VanDeBogart, 2011-02-17 23:49:34]

I don't know the windows APIs, but LGTM with nits.

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:184: LOGFONT      lf;
Did you introduce some tab characters?

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:192:
SkScalerContext_Windows::SkScalerContext_Windows(const SkDescriptor* desc)
Trailing whitespace?

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:253: ddc, &sc, c, 2, 1, &si[0].a, &index, log,
&vsa, &glyphs)));
Do cMaxGlyphs and sizeof(index) match?  The units of measure aren't clear to me.

[Chris Guillory, 2011-02-18 00:06:51]

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:184: LOGFONT      lf;
On 2011/02/17 23:49:34, Steve VanDeBogart wrote:
> Did you introduce some tab characters?
Added an additional space to keep the member names aligned. Could remove.

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:192:
SkScalerContext_Windows::SkScalerContext_Windows(const SkDescriptor* desc)
On 2011/02/17 23:49:34, Steve VanDeBogart wrote:
> Trailing whitespace?

Done.

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:253: ddc, &sc, c, 2, 1, &si[0].a, &index, log,
&vsa, &glyphs)));
On 2011/02/17 23:49:34, Steve VanDeBogart wrote:
> Do cMaxGlyphs and sizeof(index) match?  The units of measure aren't clear to
me.
cMaxGlyphs is the number of items in the &index of &vsa arrays here.
http://maxradi.us/documents/uniscribe/

[Steve VanDeBogart, 2011-02-18 00:12:23]

LGTM

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:184: LOGFONT      lf;
On 2011/02/18 00:06:51, Chris Guillory wrote:
> On 2011/02/17 23:49:34, Steve VanDeBogart wrote:
> > Did you introduce some tab characters?
> Added an additional space to keep the member names aligned. Could remove.

Oh, I see now. :-/

http://codereview.appspot.com/4172054/diff/6001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:253: ddc, &sc, c, 2, 1, &si[0].a, &index, log,
&vsa, &glyphs)));
On 2011/02/18 00:06:51, Chris Guillory wrote:
> On 2011/02/17 23:49:34, Steve VanDeBogart wrote:
> > Do cMaxGlyphs and sizeof(index) match?  The units of measure aren't clear to
> me.
> cMaxGlyphs is the number of items in the &index of &vsa arrays here.
> http://maxradi.us/documents/uniscribe/

Nevermind, I was off by one, seeing 2 as the sizeof index.

[reed1, 2011-02-18 12:53:55]

LGTM