Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3709)

Issue 4171049: Always call g_simple_async_result_complete in ibus_input_context_process_key_event_done. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by Yusuke Sato
Modified:
13 years, 4 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Always call g_simple_async_result_complete in ibus_input_context_process_key_event_done in order to handle IPC errors correctly.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ibusinputcontext.c View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
Yusuke Sato
currently the user-provided callback will not be called on error, I think.
13 years, 4 months ago (2011-02-14 07:47:23 UTC) #1
Peng
13 years, 4 months ago (2011-02-14 17:59:51 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b