Issue 4170058: Cleanup GL log and checkerr flags

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4170058: Cleanup GL log and checkerr flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by bsalomon

Modified:
13 years, 6 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 3 : rename _DEFAULT to _START #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -29 lines)			Patch
M	gpu/include/GrGLConfig.h	View	1 2	3 chunks	+44 lines, -26 lines	0 comments	Download
M	gpu/include/GrGLConfig_chrome.h	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
M	gpu/src/GrGLUtil.cpp	View	1 2	1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

reed1

Can these globals also/better live inside GrContext? http://codereview.appspot.com/4170058/diff/1005/gpu/include/GrGLConfig.h File gpu/include/GrGLConfig.h (right): http://codereview.appspot.com/4170058/diff/1005/gpu/include/GrGLConfig.h#newcode225 gpu/include/GrGLConfig.h:225: #if !defined(GR_GL_CHECK_ERROR_DEFAULT) ...

13 years, 6 months ago (2011-02-17 19:36:58 UTC) #2

bsalomon

These can't trivially be in the context; none of the classes that make GL calls ...

13 years, 6 months ago (2011-02-17 19:45:50 UTC) #3

LGTM

Expand All Messages | Collapse All Messages