Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4549)

Issue 4154042: Check for device lost with CheckDeviceState when using D3D9Ex.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by apatrick1
Modified:
13 years, 2 months ago
Reviewers:
dgkoch
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Check for device lost with CheckDeviceState when using D3D9Ex. According to the docs, TestCooperativeLevel is a no-op with D3D9Ex. http://msdn.microsoft.com/en-us/library/bb174348(VS.85).aspx I believe it is safe to ignore the additional return values from CheckDeviceState. Some appear to be to allow optimization when a window is occluded. The new errors seem to be best treated as device lost as we were before. Although if the device is removed (!) I'm not sure what to do. It might also be useful to communicate D3DERR_DEVICEHUNG to Chromium in the future so it can use it as a hint to back off. Tested that D3D9 and D3D9Ex take the appropriate paths through Display::isDeviceLost. Bug: http://code.google.com/p/angleproject/issues/detail?id=113 Committed: http://code.google.com/p/angleproject/source/detail?r=557

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -13 lines) Patch
M src/libEGL/Display.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/libEGL/Display.cpp View 10 chunks +36 lines, -11 lines 0 comments Download
M src/libEGL/libEGL.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2
apatrick1
I short one for you Daniel. Thanks, Al
13 years, 2 months ago (2011-02-08 21:23:44 UTC) #1
dgkoch
13 years, 2 months ago (2011-02-09 03:37:50 UTC) #2
LGTM

Daniel
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b