Use real glyph IDs in the win fonthost to better support pdf.

Use real glyph IDs in the win fonthost to better support pdf.

[reed1, 2011-02-09 22:29:40]

http://codereview.appspot.com/4142044/diff/2001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4142044/diff/2001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:224: //GetGlyphIndicesW(ddc, (WCHAR*)&uni, 1,
&index, 0);
This is still commented out. How can this work with the following change that
uses GGO_GLYPH_INDEX?

[Chris Guillory, 2011-02-09 22:48:08]

http://codereview.appspot.com/4142044/diff/2001/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4142044/diff/2001/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:224: //GetGlyphIndicesW(ddc, (WCHAR*)&uni, 1,
&index, 0);
I changed this and forgot to change it back before switching to gcl. I'll upload
again.

[reed1, 2011-02-09 22:53:30]

http://codereview.appspot.com/4142044/diff/5002/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4142044/diff/5002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:224: GetGlyphIndicesW(ddc, (WCHAR*)&uni, 1, &index,
0);
WCHAR is 32bits? I had thought it was 16bits. I ask because SkUnichar is 32bits.

[Chris Guillory, 2011-02-09 22:58:14]

http://codereview.appspot.com/4142044/diff/5002/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

http://codereview.appspot.com/4142044/diff/5002/src/ports/SkFontHost_win.cpp#...
src/ports/SkFontHost_win.cpp:224: GetGlyphIndicesW(ddc, (WCHAR*)&uni, 1, &index,
0);
It's 16 bits.
typedef wchar_t WCHAR;    // wc,   16-bit UNICODE character
Looks like this needs the conversion as in the comment.

[reed1, 2011-02-09 23:04:21]

If it is 16bits, then the code as is is probably wrong. It is quite possible
that we pass in a value that is larger than 16bits in uni.

[Chris Guillory, 2011-02-10 00:10:02]

The current implementation doesn't support values that are larger than 16bit and
I've read that GetGlyphIndices doesn't support values above the BMP
(recommendation is to use uniscribe function ScriptGetCMap).

Perhaps I can file a bug for the larger than 16bits issue as that might require
some additional testing.

[Chris Guillory, 2011-02-10 00:25:22]

http://code.google.com/p/skia/issues/detail?id=144

[reed1, 2011-02-10 14:46:51]

LGTM