Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1452)

Issue 4134041: shortened stems and flags (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by lemniskata.bernoulliego
Modified:
12 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

shortened stems and flags This improves the way that stems in forced directions are shortened and adds loads of new flags to be used with these shortened stems.

Patch Set 1 #

Total comments: 10

Patch Set 2 : now the code is using grob properties for some values like default stem length #

Patch Set 3 : Now there are some arrays used instead of switches and if..else #

Patch Set 4 : Got rid of multiple if..else (needs more work though). Backward flag co #

Patch Set 5 : Some more stylistic changes (hopefully for the better). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+731 lines, -367 lines) Patch
M lily/stem.cc View 1 2 3 4 37 chunks +261 lines, -176 lines 0 comments Download
M mf/feta-flags.mf View 1 10 chunks +467 lines, -188 lines 0 comments Download
M scm/define-grobs.scm View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 15
lemniskata.bernoulliego
This is a bogus comment. Am i doing this right? Janek
13 years, 1 month ago (2011-02-06 13:08:10 UTC) #1
MikeSol
Great work! I can't really speak to the font stuff. You can make your C++ ...
13 years, 1 month ago (2011-02-06 13:38:50 UTC) #2
lemniskata.bernoulliego
2011/2/6 <mtsolo@gmail.com>: > Great work! Thank you! > I can't really speak to the font ...
13 years, 1 month ago (2011-02-06 23:20:09 UTC) #3
mike_apollinemike.com
On Feb 6, 2011, at 6:19 PM, Jan Warchoł wrote: > 2011/2/6 <mtsolo@gmail.com>: >> Great ...
13 years, 1 month ago (2011-02-06 23:47:19 UTC) #4
Janek Warchol
New patch set uploaded.
13 years, 1 month ago (2011-02-07 13:07:40 UTC) #5
lemniskata.bernoulliego
2011/2/7 mike@apollinemike.com <mike@apollinemike.com>: > > On Feb 6, 2011, at 6:19 PM, Jan Warchoł wrote: ...
13 years, 1 month ago (2011-02-07 13:18:57 UTC) #6
mike_apollinemike.com
On Feb 7, 2011, at 8:18 AM, Jan Warchoł wrote: > 2011/2/7 mike@apollinemike.com <mike@apollinemike.com>: >> ...
13 years, 1 month ago (2011-02-07 14:35:57 UTC) #7
lemniskata.bernoulliego
2011/2/7 mike@apollinemike.com <mike@apollinemike.com> > > On Feb 7, 2011, at 8:18 AM, Jan Warchoł wrote: ...
13 years, 1 month ago (2011-02-07 20:09:44 UTC) #8
mike_apollinemike.com
On Feb 6, 2011, at 6:19 PM, Jan Warchoł wrote: > 2011/2/6 <mtsolo@gmail.com>: >> Great ...
13 years, 1 month ago (2011-02-07 20:27:51 UTC) #9
Janek Warchol
New patch set uploaded. The coding still needs some work, but i need some sleep ...
13 years, 1 month ago (2011-02-07 23:12:25 UTC) #10
Graham Percival
On Mon, Feb 07, 2011 at 06:37:29PM -0700, Carl Sorensen wrote: > I tried to ...
13 years, 1 month ago (2011-02-08 02:09:02 UTC) #11
c_sorensen
On 2/6/11 4:19 PM, "Jan Warchoł" <lemniskata.bernoulliego@gmail.com> wrote: > 2011/2/6 <mtsolo@gmail.com>: >> And I see ...
13 years, 1 month ago (2011-02-08 02:10:10 UTC) #12
Janek Warchol
New patch set uploaded. Some more stylistic changes (hopefully for the better). There are 3 ...
13 years, 1 month ago (2011-02-08 22:25:33 UTC) #13
marek1
I have created new [PATCH] issue for this: http://code.google.com/p/lilypond/issues/detail?id=1538 Marek
13 years, 1 month ago (2011-02-24 12:04:32 UTC) #14
Janek Warchol
13 years, 1 month ago (2011-02-24 15:18:43 UTC) #15
2011/2/24 Marek Klein <marek@gregoriana.sk>
>
> I have created new [PATCH] issue for this:
> http://code.google.com/p/lilypond/issues/detail?id=1538

Thanks for remembering! However, i'm afraid this issue is invalid. We
decided to divide this problem and the first part is discussed in
http://lists.gnu.org/archive/html/lilypond-devel/2011-02/msg00391.html
(i hope to upload a patch for that within a few hours).

cheers,
Janek
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b