Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1021)

Issue 4131043: [PDF] Add support for xfermodes / blend modes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Steve VanDeBogart
Modified:
13 years, 7 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Add support for xfermodes / blend modes. - Change SkGraphicState to track and set the blend mode (xfermode) for modes built in to PDF (non porter duff modes + src over). - Add SkXfermode::asMode() to retrieve xfermode as an enum for non porter duff modes. - Move SkXfermode.cpp around a bit to support asMode() -- Generally move utility functions toward the top of the file. - Make SkPDFFormXObject an isolated transparency group, as it used for saveLayer, which draws on transparent, not the device background. - Set the graphic state in drawDevice and drawBitmap in order to get the right xfermode and alpha. Committed: http://code.google.com/p/skia/source/detail?r=774

Patch Set 1 #

Patch Set 2 : Add unit test for SkXfermode::asMode #

Unified diffs Side-by-side diffs Delta from patch set Stats (+674 lines, -540 lines) Patch
M include/core/SkXfermode.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/core/SkXfermode.cpp View 3 chunks +545 lines, -529 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M src/pdf/SkPDFFormXObject.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
M src/pdf/SkPDFGraphicState.cpp View 4 chunks +76 lines, -5 lines 0 comments Download
A tests/XfermodeTest.cpp View 1 1 chunk +30 lines, -0 lines 0 comments Download
M tests/tests_files.mk View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
13 years, 7 months ago (2011-02-04 02:46:48 UTC) #1
reed1
1. Lets discuss separately reorganizing SkXfermode.cpp, and just add the new virtuals in this CL. ...
13 years, 7 months ago (2011-02-04 11:12:47 UTC) #2
Steve VanDeBogart
On 2011/02/04 11:12:47, reed1 wrote: > 1. Lets discuss separately reorganizing SkXfermode.cpp, and just add ...
13 years, 7 months ago (2011-02-04 18:27:09 UTC) #3
reed1
13 years, 7 months ago (2011-02-05 21:46:37 UTC) #4
I should have studied your changes more closely. Sorry for the delay.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b