Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1982)

Issue 4130045: [PDF] Improve PDF support in gm. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Steve VanDeBogart
Modified:
13 years, 5 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com, reed1
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Improve PDF support in gm. Currently gm ends up writing the same PDF four times. This fixes that problem, making PDF a first class citizen and providing a better framework for additional backends. Read support for PDF is still missing though. Committed: http://code.google.com/p/skia/source/detail?r=759

Patch Set 1 #

Patch Set 2 : Remove some tabs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -47 lines) Patch
M gm/gmmain.cpp View 1 2 chunks +67 lines, -47 lines 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
13 years, 5 months ago (2011-02-03 22:39:10 UTC) #1
bsalomon
On 2011/02/03 22:39:10, Steve VanDeBogart wrote: I realize the file already was tabbed in places ...
13 years, 5 months ago (2011-02-03 22:49:21 UTC) #2
Steve VanDeBogart
I tend to prefer to leave things as they are, as this preserves svn blame. ...
13 years, 5 months ago (2011-02-03 22:53:45 UTC) #3
bsalomon
13 years, 5 months ago (2011-02-03 22:59:23 UTC) #4
That's fine.

On Thu, Feb 3, 2011 at 5:53 PM, <vandebo@chromium.org> wrote:

> I tend to prefer to leave things as they are, as this preserves svn
> blame.  I'll certainly fix the tabs that show up in my diff.  But if you
> still want me to, I'll change all of them.
>
>
> http://codereview.appspot.com/4130045/
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b