Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 4121049: Cleanup SkPDFTypfaceInfo and make it more generic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Steve VanDeBogart
Modified:
13 years, 8 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com, Chris Guillory
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Cleanup SkPDFTypfaceInfo and make it more generic. Renamed to SkAdvancedTypefaceMetrics. Include Em size and return all metrics in unscaled font units. Make retrieval of advances optional. Reorder SkAdvancedTypefaceMetrics to be somewhat logical. Change the types of fields in SkAdvancedTypefaceMetrics to their minimum required size. Committed: http://code.google.com/p/skia/source/detail?r=752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -274 lines) Patch
A + include/core/SkAdvancedTypefaceMetrics.h View 5 chunks +40 lines, -51 lines 0 comments Download
M include/core/SkFontHost.h View 1 chunk +8 lines, -3 lines 0 comments Download
M include/core/SkTypeface.h View 2 chunks +7 lines, -4 lines 0 comments Download
M include/pdf/SkPDFFont.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/pdf/SkPDFFont.cpp View 18 chunks +94 lines, -67 lines 0 comments Download
M src/ports/SkFontHost_FONTPATH.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 9 chunks +121 lines, -128 lines 0 comments Download
M src/ports/SkFontHost_android.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_fontconfig.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_mac_atsui.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_mac_coretext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_none.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_simple.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Steve VanDeBogart
Let me know if you had any other changes in mind.
13 years, 8 months ago (2011-02-02 00:13:45 UTC) #1
reed1
13 years, 8 months ago (2011-02-02 01:57:58 UTC) #2
Nice. I like the clarified coordinate space (int16_t relative to unitsPerEm).

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b