Issue 4099044: Fix issue 1376 ambitus two accidentals.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4099044: Fix issue 1376 ambitus two accidentals. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Graham Percival (old account)

Modified:
13 years, 3 months ago

Reviewers:
carl.d.sorensen, Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Fix issue 1376 ambitus two accidentals. Add regtest for 1376 ambitus accidentals. When an ambitus consists of a single note with different alterations, two accidentals should be printed, no matter the key signature.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix nitpicks #

Patch Set 3 : fix another nitpick #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	input/regression/ambitus.ly	View	1 2	2 chunks	+7 lines, -1 line	0 comments	Download
	M	lily/ambitus-engraver.cc	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Neil Puttock

LGTM. http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly File input/regression/ambitus.ly (right): http://codereview.appspot.com/4099044/diff/1/input/regression/ambitus.ly#newcode8 input/regression/ambitus.ly:8: Two noteheads are displayed even for a note ...

13 years, 3 months ago (2011-01-23 18:00:23 UTC) #1

Graham Percival (old account)

On 2011/01/23 18:00:23, Neil Puttock wrote: > LGTM. Thanks! I've uploaded patchset 3, which I ...

13 years, 3 months ago (2011-01-23 18:21:11 UTC) #2

Neil Puttock

On 2011/01/23 18:21:11, Graham Percival wrote: > I've uploaded patchset 3, which I believe fixes ...

13 years, 3 months ago (2011-01-23 22:35:02 UTC) #3

Graham Percival (old account)

13 years, 3 months ago (2011-01-24 16:35:41 UTC) #5

On 2011/01/23 22:35:02, Neil Puttock wrote:
> Sorry Graham, my comment on the regtest should've been clearer: I wasn't
> proposing we add that information to the test (since it only applies to the
new
> case fixed by this patch); it's just that the original text is ambiguous (the
> part about two noteheads, since we can only see one in the altered unison
case).

Ok, no problem.  I pushed the modified regtest text, since it certainly doesn't
hurt.

Cheers,
- Graham

Expand All Messages | Collapse All Messages