Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3192)

Issue 4094047: Reject non-ASCII characters in shader source at the preprocessor level. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by kbr1
Modified:
13 years, 3 months ago
Reviewers:
VangelisK, dgkoch
CC:
angleproject-review_googlegroups.com, cevans1
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Reject non-ASCII characters in shader source at the preprocessor level. Committed: http://code.google.com/p/angleproject/source/detail?r=545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/preprocessor/scanner.c View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2
kbr1
This fixes an issue reported by cevans separately. Verified with his test case; the new ...
13 years, 3 months ago (2011-01-28 21:02:15 UTC) #1
dgkoch
13 years, 3 months ago (2011-01-28 21:04:34 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b