Issue 4080057: Beam collision engraver

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4080057: Beam collision engraver (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by MikeSol

Modified:
14 years, 1 month ago

Reviewers:
Neil Puttock

Visibility:
Public.

Description

Beam collision engraver

Patch Set 1 #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+179 lines, -0 lines)			Patch
M	lily/beam.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	lily/beam-collision-engraver.cc	View	1 chunk	+175 lines, -0 lines	0 comments	Download
M	ly/engraver-init.ly	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	scm/define-grob-properties.scm	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Neil Puttock

14 years, 3 months ago (2011-02-07 22:49:38 UTC) #1

Hi Mike,

As I suggested previously, you don't need the hack to remove automatic beams:
just acknowledge manual beams instead.  Han-Wen gave some pointers how you'd do
this: use Grob_info::event_cause () to check for a BeamEvent (using the macro
in_event_class ())

BTW, currently you're acknowledging chord tremolo beams (though if you implement
the above they would be filtered out).  Though this might be useful for
accidental avoidance, it will break down for tremolos with more than two notes
due to multiple announce_end_grob () calls in chord-tremolo-engraver.cc.

Cheers,
Neil

Expand All Messages | Collapse All Messages