[PDF] Change SkPDFFormXObject to not hold a reference to device.

[PDF] Change SkPDFFormXObject to not hold a reference to device.

This prevents two copies of the content stream from sticking around.  It also fixes an invalid memory reference because SkCanvas::internalRestore deletes the device (maybe it should just unref) after drawing it onto the main device.

Committed: http://code.google.com/p/skia/source/detail?r=773

[reed1, 2011-02-04 11:05:30]

I think you're right -- there's no reason Canvas needs to delete the device in
restore; it should simply unref it. I will make that change.

With that change, do you still want this CL?

[Steve VanDeBogart, 2011-02-04 17:55:30]

On 2011/02/04 11:05:30, reed1 wrote:
> I think you're right -- there's no reason Canvas needs to delete the device in
> restore; it should simply unref it. I will make that change.
> 
> With that change, do you still want this CL?

Yes, this change makes sense regardless of the Canvas issue.  I model I want
with the FormXObject type is that it represent the device at the time the new
object is created, so it should snapshot the needed state at that time.

[reed1, 2011-02-07 15:12:29]

LGTM