Issue 4079048: [PDF] Support image alpha channel plus a couple small fixes.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4079048: [PDF] Support image alpha channel plus a couple small fixes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Steve VanDeBogart

Modified:
13 years, 5 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] Support image alpha channel plus a couple small fixes. Fix bug in rendering paths with cubic segments. Only compress data if the compressed size is smaller than the uncompressed size. Committed: http://code.google.com/p/skia/source/detail?r=747

Patch Set 1 #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+248 lines, -67 lines)			Patch
M	include/pdf/SkPDFImage.h	View	2 chunks	+32 lines, -9 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	3 chunks	+5 lines, -1 line	0 comments	Download
M	src/pdf/SkPDFGraphicState.cpp	View	1 chunk	+1 line, -1 line	1 comment	Download
M	src/pdf/SkPDFImage.cpp	View	11 chunks	+205 lines, -55 lines	0 comments	Download
M	src/pdf/SkPDFStream.cpp	View	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

reed1

13 years, 5 months ago (2011-01-29 16:42:55 UTC) #2

Looks like a lot of new code around image extraction. It will be fun to write
some good gm/ tests for this.

LGTM

http://codereview.appspot.com/4079048/diff/1/src/pdf/SkPDFGraphicState.cpp
File src/pdf/SkPDFGraphicState.cpp (right):

http://codereview.appspot.com/4079048/diff/1/src/pdf/SkPDFGraphicState.cpp#ne...
src/pdf/SkPDFGraphicState.cpp:88: new SkPDFScalar(fPaint.getAlpha()/maxAlpha);
This works assuming scalar==float. The more portable way to express this is
either:

SkIntToScalar(fPaint.getAlpha()) / 0xFF;

or

fPaint.getAlpha() * SkScalarInvert(0xFF)

Expand All Messages | Collapse All Messages