Issue 4063046: Add gTest unittests to clang, and write the first one.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4063046: Add gTest unittests to clang, and write the first one. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by Jeffrey Yasskin

Modified:
13 years, 11 months ago

Reviewers:
daniel, daniel.dunbar

CC:
cfe-commits_cs.uiuc.edu

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Description

This doesn't include the cmake build steps, but it should let us start writing library-based tests with the plain makefiles.

Patch Set 1 #

Patch Set 2 : Get everything running at the right times. #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+256 lines, -6 lines)			Patch
M	Makefile	View	1	2 chunks	+7 lines, -5 lines	0 comments	Download
M	test/Makefile	View	1	2 chunks	+17 lines, -1 line	0 comments	Download
A	test/Unit/lit.cfg	View	1	1 chunk	+86 lines, -0 lines	0 comments	Download
A	test/Unit/lit.site.cfg.in	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
A	unittests/Frontend/FrontendActionTest.cpp	View	1	1 chunk	+76 lines, -0 lines	0 comments	Download
A	unittests/Frontend/Makefile	View	1	1 chunk	+19 lines, -0 lines	0 comments	Download
A	unittests/Makefile	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

5591boy

On 2011/01/29 09:51:12, Jeffrey Yasskin wrote: > Please take a look.

13 years, 11 months ago (2011-01-29 10:18:48 UTC) #3

daniel.dunbar

LGTM, although I think we want the CMake parts to follow closely behind. - Daniel ...

13 years, 11 months ago (2011-02-02 22:27:24 UTC) #4

Jeffrey Yasskin

13 years, 11 months ago (2011-02-03 05:02:58 UTC) #5

Thanks, I'll try to get the CMake version done asap.

On Wed, Feb 2, 2011 at 2:27 PM, Daniel Dunbar <daniel.dunbar@gmail.com> wrote:
> LGTM, although I think we want the CMake parts to follow closely behind.
>
>  - Daniel
>
>
> On Jan 29, 2011, at 1:51, jyasskin@gmail.com wrote:
>
>> Reviewers: daniel_zuster.org,
>>
>> Message:
>> Please take a look.
>>
>> Description:
>> This doesn't include the cmake build steps, but it should let us start
>> writing library-based tests with the plain makefiles.
>>
>> Please review this at http://codereview.appspot.com/4063046/
>>
>> Affected files:
>>  M     Makefile
>>  M     test/Makefile
>>  A     test/Unit/lit.cfg
>>  A     test/Unit/lit.site.cfg.in
>>  A     unittests/Frontend/FrontendActionTest.cpp
>>  A     unittests/Frontend/Makefile
>>  A     unittests/Makefile
>>
>>
>

Expand All Messages | Collapse All Messages