Do not allow clients to destroy the server-side config service for safety

Do not allow clients to destroy the server-side config service for safety.

Unset the own flag of priv->config so that the config proxy object never destroys the config service even if a client wrongly unref()s the priv->config object.

BUG=none
TEST=manually

[Peng, 2011-01-18 15:17:06]

http://codereview.appspot.com/4060041/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4060041/diff/1/src/ibusbus.c#newcode772
src/ibusbus.c:772: IBUS_PROXY (priv->config)->own = FALSE;
I think it is better to set it in IBusConfig init function, because not only
IBusBus uses Config proxy.

[Yusuke Sato, 2011-01-19 01:09:57]

fixed and tested. PTAL.

http://codereview.appspot.com/4060041/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4060041/diff/1/src/ibusbus.c#newcode772
src/ibusbus.c:772: IBUS_PROXY (priv->config)->own = FALSE;
I see. I put the code here since I thought ibus-daemon also uses
ibus_config_new(), but my guess was wrong.  bus/ibusimpl.c uses g_initable_new
to create the config proxy.

Moved the code to ibusconfig.c following your suggestion, thx.


On 2011/01/18 15:17:07, Shawn.P.Huang wrote:
> I think it is better to set it in IBusConfig init function, because not only
> IBusBus uses Config proxy.

[Peng, 2011-01-19 01:17:27]

LGTM