Issue 4056043: Keith's fix to 1472

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4056043: Keith's fix to 1472 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by MikeSol

Modified:
13 years ago

Reviewers:
Keith, Graham Percival (old account)

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Keith's fix to 1472

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -10 lines)			Patch
M	lily/separation-item.cc	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	ly/gregorian.ly	View	1 chunk	+0 lines, -1 line	0 comments	Download
	scm/define-grobs.scm	View	6 chunks	+1 line, -5 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Graham Percival (old account)

Regtest comparison shows nothing suspicious, and it builds the docs from scratch. Seems good to ...

13 years, 3 months ago (2011-01-20 18:48:16 UTC) #1

Graham Percival (old account)

This patch appears to be obsolete; according to http://code.google.com/p/lilypond/issues/detail?id=1472 , Keith has an updated patch.

13 years, 3 months ago (2011-01-21 12:09:02 UTC) #2

Keith

13 years, 3 months ago (2011-01-21 21:38:10 UTC) #3

On 2011/01/21 12:09:02, Graham Percival wrote:
> This patch appears to be obsolete; 

Confirming.
I opened http://codereview.appspot.com/4095041/ so I can take comments

Expand All Messages | Collapse All Messages