Issue 4054041: On ChromeOS, we don't have to (and don't want to) set default preload engines.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4054041: On ChromeOS, we don't have to (and don't want to) set default preload engines. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by Yusuke Sato

Modified:
13 years, 5 months ago

Reviewers:
shawn.p.huang, Peng Huang, Peng

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

On ChromeOS, we don't have to (and don't want to) set default preload engines. BUG=none TEST=manually

Patch Set 1 #

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	bus/ibusimpl.c	View		4 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Yusuke Sato

Could you review this? The is for the chromeos branch of ibus.

13 years, 5 months ago (2011-01-17 12:35:08 UTC) #1

Peng

On 2011/01/17 12:35:08, Yusuke Sato wrote: > Could you review this? > The is for ...

13 years, 5 months ago (2011-01-17 16:00:37 UTC) #2

Yusuke Sato

Yeah, if you're fine, I would like to submit it to master (I'll do so ...

13 years, 5 months ago (2011-01-17 16:12:43 UTC) #3

Peng

13 years, 5 months ago (2011-01-17 16:17:07 UTC) #4

So please submit to master. Thanks.

On 2011/01/17 16:12:43, Yusuke Sato wrote:
> Yeah, if you're fine, I would like to submit it to master (I'll do so
tomorrow.)
> 
> Thx,
> Yusuke
> 
> On 2011/01/17 16:00:37, Shawn.P.Huang wrote:
> > On 2011/01/17 12:35:08, Yusuke Sato wrote:
> > > Could you review this?
> > > The is for the chromeos branch of ibus.
> > 
> > LGTM. I am thinking if it could be in master branch. This change will not
> effect
> > Linux Desktop, maybe maintain it in master is easier. What do you think?

Expand All Messages | Collapse All Messages