Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(268)

Issue 4051041: code review 4051041: strings: new SplitQuoted() function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 2 months ago by niemeyer
Modified:
14 years, 1 month ago
Reviewers:
rsc, r2, golang-dev
CC:
golang-dev
Visibility:
Public.

Description

strings: new SplitQuoted() function SplitQuoted() splits a string taking quotes and escaping into consideration, in a way equivalent to how a shell would do it. E.g.: `a b:"c d" 'e''f' "g\""` Would be parsed as: []string{"a", "b:c d", "ef", `g"`}

Patch Set 1 #

Patch Set 2 : code review 4051041: strings: new SplitQuoted() function #

Patch Set 3 : code review 4051041: strings: new SplitQuoted() function #

Patch Set 4 : code review 4051041: strings: new SplitQuoted() function #

Patch Set 5 : code review 4051041: strings: new SplitQuoted() function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -0 lines) Patch
M src/pkg/strings/strings.go View 1 2 2 chunks +62 lines, -0 lines 0 comments Download
M src/pkg/strings/strings_test.go View 1 2 3 4 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 6
niemeyer
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change.
14 years, 2 months ago (2011-01-17 09:03:31 UTC) #1
r2
I'm not comfortable with this. Into a standard Go package, you're putting a parser for ...
14 years, 1 month ago (2011-01-17 22:12:21 UTC) #2
niemeyer
> I'm not comfortable with this. Into a standard Go package, you're putting a > ...
14 years, 1 month ago (2011-01-17 22:18:44 UTC) #3
rsc
I don't think this belongs in the standard library at all. There are so many ...
14 years, 1 month ago (2011-01-18 00:11:18 UTC) #4
niemeyer
Understood, thanks. Closing.
14 years, 1 month ago (2011-01-18 00:26:49 UTC) #5
niemeyer
14 years, 1 month ago (2011-01-18 17:48:25 UTC) #6
*** Abandoned ***
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b