Fixed commitRect so it correctly flips the source rectangle and dest point on...

Fixed commitRect so it correctly flips the source rectangle and dest point on Y.


Committed: http://code.google.com/p/angleproject/source/detail?r=551

[apatrick1, 2011-01-27 20:49:24]

Daniel,

I extracted this from the managed texture patch I sent yesterday. It is a bug.

The reason it was not apparent for typical WebGL apps is a little complicated.
Chrome implements glTexImage2D as multiple calls to glTexSubImage2D with
subrectangles. This is so we can ship the texel data for large textures through
a relatively small shared memory buffer in smaller chunks.

At this point, the video memory D3D texture has not been allocated so
commitRect() has no effect (levelCount() returns 0 because mBaseTexture is
null). It is only when getTexture() is called that the texel data is uploaded to
the video memory texture and this just uploads the whole surface, not the
individual rectangles. So it didn't matter that the sub-rectangles used in
commitRect were wrong.

Please review.

Thanks,

Al

[apatrick1, 2011-01-27 20:49:33]

Daniel,

I extracted this from the managed texture patch I sent yesterday. It is a bug.

The reason it was not apparent for typical WebGL apps is a little complicated.
Chrome implements glTexImage2D as multiple calls to glTexSubImage2D with
subrectangles. This is so we can ship the texel data for large textures through
a relatively small shared memory buffer in smaller chunks.

At this point, the video memory D3D texture has not been allocated so
commitRect() has no effect (levelCount() returns 0 because mBaseTexture is
null). It is only when getTexture() is called that the texel data is uploaded to
the video memory texture and this just uploads the whole surface, not the
individual rectangles. So it didn't matter that the sub-rectangles used in
commitRect were wrong.

Please review.

Thanks,

Al

[dgkoch, 2011-01-28 16:49:24]

LGTM