Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2253)

Issue 4043044: [PDF] Add replacement implementations for functions missing in older freetype libs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Steve VanDeBogart
Modified:
13 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Add replacement implementations for functions missing in older freetype libs. Committed: http://code.google.com/p/skia/source/detail?r=743

Patch Set 1 #

Patch Set 2 : Make local functions static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -19 lines) Patch
M src/ports/SkFontHost_FreeType.cpp View 1 8 chunks +52 lines, -19 lines 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
It was a bit easier than I expected to (mostly) work around the stuff missing ...
13 years, 9 months ago (2011-01-27 22:41:50 UTC) #1
reed1
can we make local functions static? (e.g. getAdvances, canEmbed)
13 years, 9 months ago (2011-01-28 19:00:56 UTC) #2
Steve VanDeBogart
On 2011/01/28 19:00:56, reed1 wrote: > can we make local functions static? (e.g. getAdvances, canEmbed) ...
13 years, 9 months ago (2011-01-28 19:14:45 UTC) #3
reed1
13 years, 9 months ago (2011-01-28 19:15:49 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b