Handle GlobalEngineChanged signals from ibus-daemon.

Handle GlobalEngineChanged signals from ibus-daemon.

BUG=http://crosbug.com/11011
TEST=manually

[Peng, 2011-01-17 16:11:08]

http://codereview.appspot.com/4037042/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4037042/diff/1/src/ibusbus.c#newcode217
src/ibusbus.c:217: "org.freedesktop.IBus",
I think it is better to implementing g_signal virtual function, and use it to
handle signals from org.freedesktop.IBus. Please refer to ibusinputcontext.c. it
is a good example.

[Peng, 2011-01-18 01:59:14]

http://codereview.appspot.com/4037042/diff/1/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4037042/diff/1/src/ibusbus.c#newcode217
src/ibusbus.c:217: "org.freedesktop.IBus",
On 2011/01/17 16:11:09, Shawn.P.Huang wrote:
> I think it is better to implementing g_signal virtual function, and use it to
> handle signals from org.freedesktop.IBus. Please refer to ibusinputcontext.c.
it
> is a good example.

Sorry. It is mistake. IBusBus is not a subclass of GDBusProxy. 

BTW, it is better to has flags to control if IBusBus will watch on the signal.
Because most processes do not want care  signals of org.freedesktop.IBus. And we
should avoid waking up all process, when IBus emits a signals.

[Yusuke Sato, 2011-01-18 03:44:08]

> BTW, it is better to has flags to control if IBusBus will watch on the signal.
> Because most processes do not want care  signals of org.freedesktop.IBus. And
we
> should avoid waking up all process, when IBus emits a signals.

That sounds reasonable. I've changed the code. Please take another look.

(I'll modify libcros later so the library calls the new set_watch API in the
"connected" cb.)

[Peng, 2011-01-18 04:16:05]

http://codereview.appspot.com/4037042/diff/6001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4037042/diff/6001/src/ibusbus.c#newcode497
src/ibusbus.c:497: bus->priv->watch_ibus_signal = watch;
I think even if connection is not connected, the watch_ibus_signal should be
set.

When connection is reconnected, IBusBus should call ibus_bus_wahtch_ibus_signal
if watch_ibus_signal is TRUE.

And when connection is disconnected, IBusBus should do some clean up work.

[Yusuke Sato, 2011-01-18 04:47:43]

http://codereview.appspot.com/4037042/diff/6001/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4037042/diff/6001/src/ibusbus.c#newcode497
src/ibusbus.c:497: bus->priv->watch_ibus_signal = watch;
sorry, I misunderstood the intention of your original code (inside #if 0).
Revised the code. Please take another look.

On 2011/01/18 04:16:05, Shawn.P.Huang wrote:
> I think even if connection is not connected, the watch_ibus_signal should be
> set.
> 
> When connection is reconnected, IBusBus should call
ibus_bus_wahtch_ibus_signal
> if watch_ibus_signal is TRUE.
> 
> And when connection is disconnected, IBusBus should do some clean up work.

[Peng, 2011-01-18 12:39:25]

LGTM. Thanks