Issue 4034041: Increase GLSL version to 1.20 if the shader contains any matrix constructor...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4034041: Increase GLSL version to 1.20 if the shader contains any matrix constructor... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by kbr1

Modified:
13 years, 3 months ago

Reviewers:
dgkoch, nicolas, Alok Priyadarshi

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Increase GLSL version to 1.20 if the shader contains any matrix constructor calls taking a matrix as argument; these were reserved in GLSL 1.10. This makes http://sio29.sakura.ne.jp/tmp/webgl/index_eruru.html load correctly once https://bugs.webkit.org/show_bug.cgi?id=52390 is fixed. BUG=103 TEST=none Committed: http://code.google.com/p/angleproject/source/detail?r=534

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -16 lines)			Patch
	M	src/compiler/VersionGLSL.h	View		1 chunk	+4 lines, -2 lines	0 comments	Download
	M	src/compiler/VersionGLSL.cpp	View		4 chunks	+21 lines, -14 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

no issues from me.

Daniel

Expand All Messages | Collapse All Messages