Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(81)

Issue 4032044: Make ibus_input_context_process_key_event to be an async function (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by Peng
Modified:
14 years, 11 months ago
Reviewers:
Yusuke Sato, fujiwara
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Export async version ibus_input_context_process_key_event. Some application may want to integrate with ibus directly, and want to use async mode for processing key events. So I make ibus_input_context_process_key_event to be an async function, and also added ibus_input_context_process_key_event_sync. Fix problem in introspection of Engine. BUG=none TEST=Tested in Ubuntu 10.10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -100 lines) Patch
M client/gtk2/ibusimcontext.c View 6 chunks +131 lines, -45 lines 0 comments Download
M client/x11/main.c View 1 chunk +4 lines, -4 lines 0 comments Download
M debian/libibus-1.0-0.symbols View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ibusengine.c View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ibusinputcontext.h View 2 chunks +47 lines, -2 lines 0 comments Download
M src/ibusinputcontext.c View 2 chunks +92 lines, -49 lines 0 comments Download

Messages

Total messages: 3
Peng
14 years, 11 months ago (2011-01-27 00:43:08 UTC) #1
fujiwara
On 2011/01/27 00:43:08, Shawn.P.Huang wrote: Looks a nice patch. I tested it. One typo: --- ...
14 years, 11 months ago (2011-01-27 03:52:54 UTC) #2
Yusuke Sato
14 years, 11 months ago (2011-01-27 14:57:03 UTC) #3
lgtm

On 2011/01/27 03:52:54, fujiwara wrote:
> On 2011/01/27 00:43:08, Shawn.P.Huang wrote:
> 
> Looks a nice patch. I tested it.
> 
> One typo:
> --- ibusinputcontext.h
> +++ ibusinputcontext.h
> @@ -160,7 +160,7 @@ void         ibus_input_context_process_
>                                               gpointer            user_data);
>  
>  /**
> - * ibus_input_context_process_key_event:
> + * ibus_input_context_process_key_event_finish:
>   * @context: An IBusInputContext.
>   * @res: A GAsyncResult obtained from the GAsyncReadyCallback passed to
>   *   ibus_input_context_process_key_event().
> 
> 
> Maybe you like to fix several indent issues. e.g.
> --- ibusimcontext.c
> +++ ibusimcontext.c
> @@ -243,9 +243,9 @@ _process_key_event_done (GObject      *o
>  
>      gboolean processed = FALSE;
>      if (!ibus_input_context_process_key_event_finish (context,
> -                                                     res,
> -                                                     &processed,
> -                                                     NULL)) {
> +                                                      res,
> +                                                      &processed,
> +                                                      NULL)) {
>          processed = FALSE;
>      }
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b