[PDF] Clean up ref counting.

[PDF] Clean up ref counting.

Return ref'd objs where possible enabling removal of many SkRefPtr<> variables.

Committed: http://code.google.com/p/skia/source/detail?r=750

[Steve VanDeBogart, 2011-02-01 18:51:43]

Thanks for making the suggestion, this pattern has made some of the PDF code
more readable (at the cost of a bit of density).

[reed1, 2011-02-01 18:56:32]

As I noted in the first header, I think the API documentation should point out
when an argument's reference-count is modified (ref'd) by the function.

http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h
File include/pdf/SkPDFCatalog.h (right):

http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h#newco...
include/pdf/SkPDFCatalog.h:43: SkPDFObject* addObject(SkPDFObject* obj, bool
onFirstPage);
Can the comment also note that obj->ref() will be called.

[Steve VanDeBogart, 2011-02-01 19:00:40]

http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h
File include/pdf/SkPDFCatalog.h (right):

http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h#newco...
include/pdf/SkPDFCatalog.h:43: SkPDFObject* addObject(SkPDFObject* obj, bool
onFirstPage);
On 2011/02/01 18:56:32, reed1 wrote:
> Can the comment also note that obj->ref() will be called.

On the first line of the comment I added "Refs obj."  Where/how would you like
me to add this information?

[reed1, 2011-02-01 19:05:15]

Ah, I didn't see that. That sounds good.

On Tue, Feb 1, 2011 at 2:00 PM, <vandebo@chromium.org> wrote:

>
> http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h
> File include/pdf/SkPDFCatalog.h (right):
>
>
>
http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h#newco...
> include/pdf/SkPDFCatalog.h:43: SkPDFObject* addObject(SkPDFObject* obj,
> bool onFirstPage);
> On 2011/02/01 18:56:32, reed1 wrote:
>
>> Can the comment also note that obj->ref() will be called.
>>
>
> On the first line of the comment I added "Refs obj."  Where/how would
> you like me to add this information?
>
>
> http://codereview.appspot.com/4029051/
>

[Steve VanDeBogart, 2011-02-01 21:41:28]

Sorry, was that a LGTM?

On 2011/02/01 19:05:15, reed1 wrote:
> Ah, I didn't see that. That sounds good.
> 
> On Tue, Feb 1, 2011 at 2:00 PM, <mailto:vandebo@chromium.org> wrote:
> 
> >
> > http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h
> > File include/pdf/SkPDFCatalog.h (right):
> >
> >
> >
>
http://codereview.appspot.com/4029051/diff/1/include/pdf/SkPDFCatalog.h#newco...
> > include/pdf/SkPDFCatalog.h:43: SkPDFObject* addObject(SkPDFObject* obj,
> > bool onFirstPage);
> > On 2011/02/01 18:56:32, reed1 wrote:
> >
> >> Can the comment also note that obj->ref() will be called.
> >>
> >
> > On the first line of the comment I added "Refs obj."  Where/how would
> > you like me to add this information?
> >
> >
> > http://codereview.appspot.com/4029051/
> >

[reed1, 2011-02-01 21:57:03]

LGTM