Issue 4014041: Make KeyCancellation independent of extraNatural

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4014041: Make KeyCancellation independent of extraNatural (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by Keith

Modified:
13 years, 2 months ago

Reviewers:
Neil Puttock

CC:
lilypond-devel_gnu.org

Visibility:
Public.

Description

Make KeyCancellation independent of extraNatural Simplify code, remove regtest that tested partial key cancellations

Patch Set 2 : whitespace #

Created: 13 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -27 lines)			Patch
	D	input/regression/key-signature-cancellation-extra-natural.ly	View		1 chunk	+0 lines, -23 lines	0 comments	Download
	M	lily/key-engraver.cc	View	1	2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Graham Percival (old account)

This patch appears to be have been created in "reversed" fashion -- I'm certain that ...

13 years, 2 months ago (2011-01-30 15:29:15 UTC) #1

Keith

On 2011/01/30 15:29:15, Graham Percival wrote: > This patch appears to be have been created ...

13 years, 2 months ago (2011-01-30 18:08:40 UTC) #2

Neil Puttock

LGTM. http://codereview.appspot.com/4014041/diff/1/lily/key-engraver.cc File lily/key-engraver.cc (right): http://codereview.appspot.com/4014041/diff/1/lily/key-engraver.cc#newcode92 lily/key-engraver.cc:92: || (ly_scm2rational (scm_cdr (new_alter_pair)) - old_alter) * old_alter ...

13 years, 2 months ago (2011-02-07 22:10:35 UTC) #3

Keith

13 years, 2 months ago (2011-02-08 03:18:27 UTC) #4

all pretty now

http://codereview.appspot.com/4014041/diff/1/lily/key-engraver.cc
File lily/key-engraver.cc (right):

http://codereview.appspot.com/4014041/diff/1/lily/key-engraver.cc#newcode93
lily/key-engraver.cc:93: < Rational (0))
On 2011/02/07 22:10:35, Neil Puttock wrote:
> indent (align with || above)

The indent was correct, but GNU recommends extra parentheses here (coding
standard section 5.1 near the end) so that emacs doesn't mess it up.

Expand All Messages | Collapse All Messages