Issue 40053: Make editing a branch actually edit, rather than creating a new branch

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40053: Make editing a branch actually edit, rather than creating a new branch (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
17 years, 2 months ago by Collin Winter

Modified:
16 years, 10 months ago

Reviewers:
Andi Albrecht

CC:
GvR

Base URL:
http://rietveld.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Currently, editing a branch creates a new branch using the new data. This patch fixes this to update the branch in-place. Also, remove the ability to edit the branch's repository name manually, since this wouldn't actually change the repository name.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments #

Created: 17 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	codereview/views.py	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
	M	templates/branch_edit.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Collin Winter

Andi, can you please review this patch for Rietveld?

17 years, 2 months ago (2009-04-10 23:25:43 UTC) #1

Andi Albrecht

LGTM, just one nit... http://codereview.appspot.com/40053/diff/1/2 File codereview/views.py (right): http://codereview.appspot.com/40053/diff/1/2#newcode2444 Line 2444: branch.repo_name = repo.name You ...

17 years, 2 months ago (2009-04-14 06:38:54 UTC) #2

Collin Winter

http://codereview.appspot.com/40053/diff/1/2 File codereview/views.py (right): http://codereview.appspot.com/40053/diff/1/2#newcode2444 Line 2444: branch.repo_name = repo.name On 2009/04/14 06:38:54, andi.albrecht wrote: ...

17 years, 2 months ago (2009-04-14 20:53:40 UTC) #3

Andi Albrecht

17 years, 2 months ago (2009-04-14 21:04:35 UTC) #4

On 2009/04/14 20:53:40, Collin Winter wrote:
> http://codereview.appspot.com/40053/diff/1/2
> File codereview/views.py (right):
> 
> http://codereview.appspot.com/40053/diff/1/2#newcode2444
> Line 2444: branch.repo_name = repo.name
> On 2009/04/14 06:38:54, andi.albrecht wrote:
> > You can access the Repository instance using "branch.repo".
> 
> Done.

Committed r408. Thanks Collin!

Expand All Messages | Collapse All Messages