Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(104)

Issue 4001057: Manually convert files to version 2.13.46 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Keith
Modified:
13 years, 2 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Manually convert files to version 2.13.46 Vertical-spacing changes that could not be determined by convert-ly

Patch Set 1 #

Total comments: 4

Patch Set 2 : second pass through sources #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -31 lines) Patch
M Documentation/de/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/learning/common-notation.itely View 2 chunks +2 lines, -2 lines 0 comments Download
M Documentation/it/learning/common-notation.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/learning/common-notation.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/learning/tutorial.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/learning/common-notation.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/notation/changing-defaults.itely View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/snippets/engravers-one-by-one.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web/ly-examples/orchestra.ly View 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web/ly-examples/sesto-full.ly View 1 2 chunks +1 line, -4 lines 1 comment Download
M input/regression/grid-lines.ly View 1 chunk +0 lines, -1 line 0 comments Download
M input/regression/lyrics-tenor-clef.ly View 1 chunk +3 lines, -10 lines 0 comments Download
M input/regression/spacing-to-empty-barline.ly View 1 2 chunks +1 line, -3 lines 0 comments Download
M ly/performer-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Keith
http://codereview.appspot.com/4001057/diff/1/Documentation/learning/common-notation.itely File Documentation/learning/common-notation.itely (right): http://codereview.appspot.com/4001057/diff/1/Documentation/learning/common-notation.itely#newcode1282 Documentation/learning/common-notation.itely:1282: c4^\name False match http://codereview.appspot.com/4001057/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4001057/diff/1/Documentation/notation/changing-defaults.itely#newcode780 Documentation/notation/changing-defaults.itely:780: ...
13 years, 3 months ago (2011-02-05 10:45:16 UTC) #1
Graham Percival (old account)
LGTM, please send me the final patch.
13 years, 2 months ago (2011-02-05 17:54:43 UTC) #2
Neil Puttock
LGTM. http://codereview.appspot.com/4001057/diff/1/Documentation/snippets/engravers-one-by-one.ly File Documentation/snippets/engravers-one-by-one.ly (right): http://codereview.appspot.com/4001057/diff/1/Documentation/snippets/engravers-one-by-one.ly#newcode4 Documentation/snippets/engravers-one-by-one.ly:4: \version "2.13.46" This shouldn't be converted: running makelsr.py ...
13 years, 2 months ago (2011-02-05 18:10:25 UTC) #3
Keith
On a second pass I found one version number I had missed, and one mistake. ...
13 years, 2 months ago (2011-02-05 19:11:22 UTC) #4
Neil Puttock
13 years, 2 months ago (2011-02-05 21:10:16 UTC) #5
On 5 February 2011 19:11,  <k-ohara5a5a@oco.net> wrote:

> I think the appropriate solution is to copy the file into snippets/new,
> but need to check with the build-meister.

We only add snippets to snippets/new/ if they rely on new code or
convert-ly fails (usually due to a NOT_SMART rule).

Cheers,
Neil
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b