On a second pass I found one version number I had missed, and one mistake. ...
13 years, 2 months ago
(2011-02-05 19:11:22 UTC)
#4
On a second pass I found one version number I had missed, and one mistake.
Posted and mailed to Graham.
On 2011/02/05 18:10:25, Neil Puttock wrote:
> LGTM.
>
>
http://codereview.appspot.com/4001057/diff/1/Documentation/snippets/engravers...
> Documentation/snippets/engravers-one-by-one.ly:4: \version "2.13.46"
> This shouldn't be converted: running makelsr.py will change it back to 2.12.2
> (since there are no changes in the file between 2.12.2 and master).
I think the appropriate solution is to copy the file into snippets/new, but need
to check with the build-meister.
http://codereview.appspot.com/4001057/diff/7002/Documentation/web/ly-examples...
File Documentation/web/ly-examples/sesto-full.ly (right):
http://codereview.appspot.com/4001057/diff/7002/Documentation/web/ly-examples...
Documentation/web/ly-examples/sesto-full.ly:54: \description "Like StaffGroup,
but without spanbar"
Restore these user-defined contexts; I thought they were identical to ChoirStaff
but they are not.
On 5 February 2011 19:11, <k-ohara5a5a@oco.net> wrote: > I think the appropriate solution is to ...
13 years, 2 months ago
(2011-02-05 21:10:16 UTC)
#5
On 5 February 2011 19:11, <k-ohara5a5a@oco.net> wrote:
> I think the appropriate solution is to copy the file into snippets/new,
> but need to check with the build-meister.
We only add snippets to snippets/new/ if they rely on new code or
convert-ly fails (usually due to a NOT_SMART rule).
Cheers,
Neil
Issue 4001057: Manually convert files to version 2.13.46
(Closed)
Created 13 years, 3 months ago by Keith
Modified 13 years, 2 months ago
Reviewers: Graham Percival (old account), Neil Puttock
Base URL:
Comments: 5